Re: HTTPApp.DispatchHandler bug?

Hello Kevin,

This code does indeed look suspicious. As it's not in the SOAP area but
rather in WebBroker (which is what SOAP builds on top of), I'll let someone
else make the ca;; but, Yes, I would suggest reporting it. I'll bring it up
with the WebBroker person also.

The current logic would dispatch strictly based on path and ignore the
MethodType (unless mtAny) was specified. Maybe few people used the same path
and have different logic based on GET vs. POST etc. In SOAP we keep the GET
(for WSDL) and POST (for SOAP request) in distinct paths.. so we would never
encounter this issue.

Thanks for bringing this up. And do let me know the QC#. I'll forward it.

Cheers,

Bruneau.

In debugging another problem I was having, I noticed this piece of code seems
broken but I wanted to get some confirmation before I report it to QC:

function DispatchHandler(Sender: TObject; Dispatch: IWebDispatch; Request:
TWebRequest; Response: TWebResponse;
  DoDefault: Boolean): Boolean;
begin
  Result := False;
  if (Dispatch.Enabled and ((Dispatch.MethodType = mtAny) or
    (Dispatch.MethodType = Dispatch.MethodType)) and
    Dispatch.Mask.Matches(Request.InternalPathInfo)) then
  begin
    Result := Dispatch.DispatchRequest(Sender, Request, Response);
  end;
end;

Shouldn't "Dispatch.MethodType = Dispatch.MethodType" be
"Request.MethodType = Dispatch.MethodType"?

The QC# is 57926.  I wasn't sure where to put it in QC either.  Couldn't locate
a WebBroker section.

kd

"Jean-Marie Babet" <bbabet@borland.com> wrote in message
news:47a21202$1@newsgroups.borland.com...
> Hello Kevin,
> 
> This code does indeed look suspicious. As it's not in the SOAP area but
> rather in WebBroker (which is what SOAP builds on top of), I'll let
someone
> else make the ca;; but, Yes, I would suggest reporting it. I'll bring it
up
> with the WebBroker person also.
> 
> The current logic would dispatch strictly based on path and ignore the
> MethodType (unless mtAny) was specified. Maybe few people used the same
path
> and have different logic based on GET vs. POST etc. In SOAP we keep the
GET
> (for WSDL) and POST (for SOAP request) in distinct paths.. so we would
never
> encounter this issue.
> 
> Thanks for bringing this up. And do let me know the QC#. I'll forward it.
> 
> Cheers,
> 
> Bruneau.
>